Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure.Identity to version 1.10.3 along with downstream packages. #300

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

dustinburson
Copy link
Member

Update Azure.Identity package to address known vulnerability.

@dustinburson dustinburson requested a review from a team as a code owner October 19, 2023 22:19
@kyclai
Copy link
Contributor

kyclai commented Oct 19, 2023

Some packages have a dependency on Azure.Identity < 1.10.3, such as the following. Do they need to be updated too?

  • Microsoft.Extensions.Azure: "Azure.Identity": "1.4.0"
  • Microsoft.Health.Client: "Azure.Identity": "1.10.0"

@kyclai
Copy link
Contributor

kyclai commented Oct 19, 2023

https://github.com/microsoft/iomt-fhir/blob/main/src/console/packages.lock.json references Azure.Identity 1.9.0. Does this need to be updated too?

rogordon01
rogordon01 previously approved these changes Oct 19, 2023
@dustinburson
Copy link
Member Author

dustinburson commented Oct 19, 2023

https://github.com/microsoft/iomt-fhir/blob/main/src/console/packages.lock.json references Azure.Identity 1.9.0. Does this need to be updated too?

Thanks for the call out Carrie. The package.lock files are automatically generated. The syntax [1.9.0, ) means the min version is 1.9 but can go higher unbounded.

Edit: I took a second look. This particular file seems to be old from when we had src/console/Microsoft.Health.Fhir.Ingest.Console.csproj in the directory. That project was deleted but it looks like the lock file was left behind. It is non functional. I went ahead and deleted it in this PR since I had to make another change.

@dustinburson
Copy link
Member Author

dustinburson commented Oct 19, 2023

Some packages have a dependency on Azure.Identity < 1.10.3, such as the following. Do they need to be updated too?

  • Microsoft.Extensions.Azure: "Azure.Identity": "1.4.0"
  • Microsoft.Health.Client: "Azure.Identity": "1.10.0"

I am running our internal compliance build to verify but I don't think it is an issue. Our package version should be forcing the use of 1.10.3.

Edit: Running the internal compliance found we were still using Azure.Identity 1.10 in the in the Microsoft.Health.Test.Utilities.proj. This was through the FHIR Client package you mentioned. Other projects were fine because they either had the package reference directly or transitively through Microsoft.Health.Common. This test project was the one exception. Pushing a new commit to address.

@dustinburson dustinburson merged commit 29c2012 into main Oct 20, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants